Enable initial r support#2721
Merged
AndreasArvidsson merged 28 commits intocursorless-dev:mainfrom May 25, 2025
Merged
Conversation
Contributor
Author
|
I'm marking this as ready to make adding scopes easier. Once r support is included in cursorless, it will be easier for it to pick it up as an option for adding scopes |
Member
|
Latest version of the parse tree is published and should be available in the marketplace very soon. |
BlueDrink9
commented
May 15, 2025
Contributor
Author
|
@AndreasArvidsson ready to review! Thank you again for your help yesterday |
Member
|
Please add a scope test for an empty argument list as well. The difference is the insertion delimiter. Please have a look at how it's implemented in other languages. |
Member
|
I would recommend that you create multiple scope files for the same facet instead of adding multiple different code examples in the same file. It's much simpler to review it that way. |
AndreasArvidsson
requested changes
May 16, 2025
BlueDrink9
force-pushed
the
main
branch
2 times, most recently
from
8bb8dee to
3bf717c
Compare
BlueDrink9
commented
May 23, 2025
Member
|
Looks like you're starting to get the hang of this :)
|
Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
AndreasArvidsson
requested changes
May 25, 2025
AndreasArvidsson
approved these changes
May 25, 2025
AndreasArvidsson
approved these changes
May 25, 2025
Member
|
@BlueDrink9 Regarding iteration domain for arguments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still wrapping my head around treesitter to add the supported scopes, so I'll update this PR and add relevant tests once I do + once the r PR is added to vscode's parse tree
Checklist